Code Review Boards - How to stay professional

I have recently come across the concept of a code review board. At first it was an awkward moment; My change set was out there for all the world to see and comment. I admit I was stressed about it and with good reason. What I will do in this post is put the record straight, as far as I am concerned, on the good, the bad and the ugly of public/social code reviews. And since in the near future my code will be standing there naked for all to see on some public repository, this should make for a very good exercise on what to expect and what to reject when it comes to review boards. TL;DR Code reviews are good. Review boards meh...

Past (nearly) perfect

At some point during my searching for topics to write I recalled some articles I wrote back in the day on CodeProject. And I also do remember that, unless your article was pure garbage, review of the article and comments where polite, leveled and cool headed. Social media was not that proliferated and people did not openly enjoy putting others in a defensive position on a whim. Oh and by the way one can find links for those articles in this static page in this blog.

The Good

The good thing about having people crowd-review your code is that you get everyone's perspective on what you wrote, be it for the design of your code, potential bugs, or best practices. In a perfect world you can have a professional discussion about it and solve problems, decide on a course of action on technical debts or develop a philosophical discussion.

The Bad

The bad thing about review boards (especially when they are group wide), are the email "noise" they produce. Every single comment will be, most definitely, sent by email to every member in the group at any time of the day... or night.

The Ugly

Although code reviews are good and between professionals are even better, there is always that person with the annoying comments. The person who has something to say no matter what. Who doesn't like your naming scheme. Who thinks that if(A && B)is not clear enough (to this person's opinion) then the elements around the && have to be switched. The petty one. Be polite but precise and assertive to your answers to that person. Be constructive when commenting that person's code. Be professional. Hopefully that person will get off your back. Hopefully but not probably.  

Having said all that, in the link below is the base repository on which quite a few post will be based upon. And it has a bug!!! Can you spot it without running the code (review it)? Can you spot it after reading the code, running but not debugging? Leave a comment below and let me know!

Producer/Consumer Repo 

Comments

  1. AnonymousAugust 11, 2026 at 3:52 AM

    The article offers a thoughtful discussion of code review boards, balancing the benefits of collaborative feedback with the practical challenges of public or group-wide reviews. I appreciate how the author separates the good, bad, and ugly aspects, particularly the value of receiving different perspectives on design, bugs, best practices, and technical debt while also recognizing the stress and communication issues that can accompany public review.

    The discussion emphasizes that effective code reviews should encourage professional, constructive conversations rather than personal criticism. The observations about review comments, email noise, naming preferences, and maintaining a precise and assertive response provide useful lessons for software teams. This collaborative development perspective makes Python Coding Course a relevant learning area for developers who want to strengthen their programming practices and produce code that can withstand structured review.

    ReplyDelete
  2. AnonymousAugust 11, 2026 at 3:54 AM

    The article’s closing challenge, asking readers to identify a bug through code review and then compare that experience with running the code without debugging, adds an engaging practical dimension. It reinforces the importance of reading code carefully, communicating observations constructively, and separating useful technical feedback from personal preferences. These practices are also valuable for learners developing disciplined programming habits through Python Coding Training, where writing understandable and maintainable code is an important foundation.

    ReplyDelete

Post a Comment

Keep it clean, professional and constructive. Everything else including ethnic or religious references will be removed.

Popular posts from this blog

Running an Asp.Net Core 2.* Web API as a Windows Service

Image
At my current workplace there is a healthy hunger for new technologies and a pragmatic view of the software industry in our corner of the planet. As a Microsoft driven shop, previous reservations of moving to different ecosystems and operating systems have melted away with the arrival and wide adoption of .Net Core. After all the language is the same. The developers need "only" to catch up on their containers. When I joined a month ago as a tech lead, little did I know that putting my money where my mouth is would mean having to deal with outdated Microsoft documentation or even S.O answers to questions such as "How do I run an Asp.Net Core app as a windows service without IIS". TL;DR add a reference to the NuGet package  Microsoft.Aspnetcore.Hosting.Windowsservices , publish and register your executable as a service. A Prophecy? Almost a year ago I wrote a blog post about porting  full framework projects to core . Ever since I have written my share of .Net Cor...
Read more

Reviving old hardware en mass or: How I Learned to Stop Worrying and Love the ZorinOS Linux Distribution

Image
Let's see how we can help upgrade and stabilize the school's computers in the classes and labs he said .  But as I wrote before the Local Council's finances are in dire straights.   TL;DR The end may be happy. but the journey was glorious. ZorinOS Logo  Copyright © 2014 - 2020 Zorin Technology Group Ltd. All Rights Reserved. The state of computers in classes and labs Hardware ranging from the last generation of dual core Pentiums to 4th generation i7s with a sprinkle of, surprisingly fast but with very low memory and cache, dual core 64bit AMDs. Packed with dust, ridden with useless software and desktops full of documents over Windows 7 and some Windows 10 build 1803 or less. The list of complaints on slow or stuck PCs is getting longer by the day. The phrase "It does not work" appears in every other row on a spreadsheet. It is the end of June 2019, School year starts September 1st, the teachers do not know what they need on the PCs but they need it...
Read more

Evaluating NDepend on current codebase Part 2

Image
In Part 1 we saw a first approach to NDepend starting off with analyzing a project of 2 assemblies and focusing on the smaller assembly. In this part we will focus on the main executable and the gems NDepend discovered in it TL; DR Memory leak detected... Photo by  Daan Mooij  on  Unsplash Enter 3 years old WPF project - Main executable Going back to the dashboard I see the "usual" long types or methods errors, some immutability warnings, which I would have set as errors and 400 violations of "Avoid namespaces mutually dependent" some with debt time of 4 days. "Oh come on.. what 4 days. How hard can it be..." Drilling down into the code (a wpf application) I realize that there is a single class that is injected in the constructor of every view model and I hardly see any services in the system save for calls to the DAL assembly. Without drilling down into the class I changed it's namespace and made the necessary, albeit sisyphic, chan...
Read more